Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: limit amount of workers on CI #2014

Merged
merged 1 commit into from
May 12, 2023
Merged

chore: limit amount of workers on CI #2014

merged 1 commit into from
May 12, 2023

Conversation

dmitry-stepanenko
Copy link
Contributor

@dmitry-stepanenko dmitry-stepanenko commented May 12, 2023 •
edited
Loading

It looks like on CircleCI unit tests task throws due to memory issues https://discuss.circleci.com/t/jest-unit-test-works-locally-but-fail-on-circleci-docker-image-cimg-node-16-13/42620/2

This can happen when the script looks at the number of CPUs available on the physical machine, which can be 32+ cores, rather than the number vCPUs the Docker container has been allocated.

I was able to get the error code 137 by running yarn jest -c packages/store/jest.config.js. I guess because node just kills the process Nx is not able to handle the exit properly

@nx-cloud
Copy link

nx-cloud bot commented May 12, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d4715ff. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

@dmitry-stepanenko dmitry-stepanenko marked this pull request as ready for review May 12, 2023 06:38
@dmitry-stepanenko dmitry-stepanenko force-pushed the ds/test-ci branch 2 times, most recently from 00da7d5 to 9ae6b7c Compare May 12, 2023 06:45
@bundlemon
Copy link

bundlemon bot commented May 12, 2023 •
edited
Loading

BundleMon

Unchanged files (3)
Status Path Size Limits
✅ fesm2015/ngxs-store.js
 94.34KB 125KB / +0.5%
✅ fesm2015/ngxs-store-operators.js
 6.23KB 15KB / +0.5%
✅ fesm2015/ngxs-store-internals.js
 4.22KB 20KB / +0.5%

No change in files bundle size

Unchanged groups (3)
Status Path Size Limits
✅ @ngxs/store(esm2015)[gzip]
./esm2015/**/*.js
 181.33KB +1%
✅ @ngxs/store(umd)[gzip]
./bundles/*.umd.js
 36.63KB +1%
✅ @ngxs/store(fesm2015)[gzip]
./fesm2015/*.js
 25.09KB +1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented May 12, 2023 •
edited
Loading

BundleMon (NGXS Plugins)

Unchanged files (14)
Status Path Size Limits
✅ Plugins(umd)[gzip]
storage-plugin/bundles/ngxs-storage-plugin.um
d.js
 7.96KB +1%
✅ Plugins(umd)[gzip]
router-plugin/bundles/ngxs-router-plugin.umd.
js
 7.41KB +1%
✅ Plugins(umd)[gzip]
websocket-plugin/bundles/ngxs-websocket-plugi
n.umd.js
 6.92KB +1%
✅ Plugins(umd)[gzip]
hmr-plugin/bundles/ngxs-hmr-plugin.umd.js
 6.89KB +1%
✅ Plugins(fesm2015)[gzip]
storage-plugin/fesm2015/ngxs-storage-plugin.j
s
 3.64KB +1%
✅ Plugins(umd)[gzip]
form-plugin/bundles/ngxs-form-plugin.umd.js
 3.44KB +1%
✅ Plugins(fesm2015)[gzip]
router-plugin/fesm2015/ngxs-router-plugin.js
 3.09KB +1%
✅ Plugins(umd)[gzip]
devtools-plugin/bundles/ngxs-devtools-plugin.
umd.js
 2.75KB +1%
✅ Plugins(fesm2015)[gzip]
form-plugin/fesm2015/ngxs-form-plugin.js
 2.67KB +1%
✅ Plugins(fesm2015)[gzip]
hmr-plugin/fesm2015/ngxs-hmr-plugin.js
 2.65KB +1%
✅ Plugins(fesm2015)[gzip]
websocket-plugin/fesm2015/ngxs-websocket-plug
in.js
 2.59KB +1%
✅ Plugins(umd)[gzip]
logger-plugin/bundles/ngxs-logger-plugin.umd.
js
 2.53KB +1%
✅ Plugins(fesm2015)[gzip]
devtools-plugin/fesm2015/ngxs-devtools-plugin
.js
 2.17KB +1%
✅ Plugins(fesm2015)[gzip]
logger-plugin/fesm2015/ngxs-logger-plugin.js
 2.01KB +1%

No change in files bundle size

Unchanged groups (3)
Status Path Size Limits
✅ All Plugins(esm2015)[gzip]
./-plugin/esm2015/**/.js
 108.71KB +1%
✅ All Plugins(umd)[gzip]
./-plugin/bundles/.umd.js
 37.91KB +1%
✅ All Plugins(fesm2015)[gzip]
./-plugin/fesm2015/.js
 18.82KB +1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented May 12, 2023 •
edited
Loading

BundleMon (Integration Projects)

Unchanged files (3)
Status Path Size Limits
✅ Main bundles(Gzip)
hello-world-ng13-ivy/dist-integration/main.(h
ash).js
 69.8KB +1%
✅ Main bundles(Gzip)
hello-world-ng12-ivy/dist-integration/main.(h
ash).js
 67.95KB +1%
✅ Main bundles(Gzip)
hello-world-ng14-ivy/dist-integration/main.(h
ash).js
 64.86KB +1%

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@dmitry-stepanenko dmitry-stepanenko force-pushed the ds/test-ci branch 5 times, most recently from b1394d9 to 49a47af Compare May 12, 2023 07:13
@dmitry-stepanenko dmitry-stepanenko changed the title chore: test ci chore: limit amount of workers on CI May 12, 2023
@dmitry-stepanenko dmitry-stepanenko mentioned this pull request May 12, 2023
Merged
@codeclimate
Copy link

codeclimate bot commented May 12, 2023

Code Climate has analyzed commit d4715ff and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

@markwhitfeld markwhitfeld merged commit a827bb0 into ngxs:master May 12, 2023
@markwhitfeld markwhitfeld added this to the v3.8.1 milestone May 17, 2023
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markwhitfeld markwhitfeld markwhitfeld approved these changes

@arturovt arturovt Awaiting requested review from arturovt arturovt is a code owner

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
v3.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@dmitry-stepanenko @markwhitfeld